Conversation
feanil
force-pushed
the
feanil/drop_python_3.11
branch
from
04098c9 to
6461925
Compare
Remove Python 3.11 from all CI workflow matrices and update requires-python to >=3.12 in pyproject.toml. Also remove ubuntu-22.04 compatibility include entries from unit-tests.yml that were tied to Python 3.11 testing. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
pylint was upgraded from 3.x to 4.x by make upgrade, which now enforces the 120-char line limit more strictly. - cms/envs/devstack.py, production.py: split long lines in triple-quoted string literals (Markdown text, so Python newlines become spaces — no content change) - test_containers.py: add pylint disable/enable around OLX assertion block where XML attribute strings cannot be split Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
feanil
force-pushed
the
feanil/drop_python_3.11
branch
from
221ae18 to
620567e
Compare
| Please see separately provided documentation. | ||
| \n - How to test: You must be logged in as course author for whatever course you want to test with. | ||
| You can use the [Swagger UI](https://{CMS_BASE}/authoring-api/ui/) to "Try out" the API with your test course. To do this, you must select the "Local" server. | ||
| You can use the [Swagger UI](https://{CMS_BASE}/authoring-api/ui/) to "Try out" the API |
There was a problem hiding this comment.
Note for Reviews: Fix due to a newer version of pylint getting pulled in which is stricter about line lenght and better at detecting this violation.
setuptools 82+ removed pkg_resources, which pyfilesystem2 (fs) still uses for namespace package declarations. The constraints.txt pin handles this for full installs, but the static-assets-check workflow only installs requirements/edx/assets.txt. Pre-installing pip-tools.txt ensures setuptools 81.x is in place before the assets install runs. See: PyFilesystem/pyfilesystem2#577 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
The two checks that are yellow are the old 3.11 required checks which we don't need because equivalent 3.12 checks are now running. I'll update the required checks list before merging this. |
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@feanil, Python 3.11 is still used in the following places:
openedx-platform/.readthedocs.yaml
Line 6 in 4c07b49
Line 81 in 4c07b49
openedx-platform/scripts/structures_pruning/README.rst
Lines 32 to 37 in 4c07b49
openedx-platform/scripts/user_retirement/README.rst
Lines 31 to 36 in 4c07b49
- (Do we even use tox in this repo?)
Line 2 in 4c07b49
| # It's useful to run some subset of the tests on the older version of Ubuntu | ||
| # so that we don't spend too many resources on this but can find major issues quickly | ||
| # while we're in a situation where we support two versions. This section may be commented | ||
| # out when not in use to easily add/drop future support for any given major dependency. | ||
| # | ||
| # We're testing the older version of Ubuntu and running the xmodule tests since those rely on many | ||
| # dependent complex libraries and will hopefully catch most issues quickly. | ||
| include: | ||
| - shard_name: "xmodule-with-cms" | ||
| python-version: "3.11" | ||
| django-version: "pinned" | ||
| mongo-version: "7.0" | ||
| os-version: "ubuntu-22.04" | ||
| - shard_name: "xmodule-with-lms" | ||
| python-version: "3.11" | ||
| django-version: "pinned" | ||
| mongo-version: "7.0" | ||
| os-version: "ubuntu-22.04" | ||
|
|
There was a problem hiding this comment.
Should we comment it out instead of removing (like described in the comment)? Or should we remove the comment as well?
2 participants
Summary
Context
Python 3.11 is being dropped across the Open edX ecosystem as part of the move
to standardize on Python 3.12. See the tracking issue for the full list of repos:
openedx/public-engineering#499
Test plan